Expands documentation for AmbientAware, adds support for AmbientDetails #1674
Conversation
| } | ||
|
|
||
| override fun onUpdateAmbient() { | ||
| ambientUpdate = AmbientStateUpdate(AmbientState.AMBIENT) | ||
| ambientUpdate = AmbientStateUpdate(AmbientState.Ambient()) |
There was a problem hiding this comment.
Can we retain the previous value?
There was a problem hiding this comment.
Yeah, I wondered about that, do these things change? I will add it.
There was a problem hiding this comment.
I don't think it's about them changing, I think more about having immediate access to it via this type.
There was a problem hiding this comment.
Added. Unfortunately, there still remains the chance of it being null, if the device is already in ambient, so onEnterAmbient has not been called. I don't think this seems very likely in practice?
There was a problem hiding this comment.
I'm not sure, we should test. If it's the case we should push it up to the Activity, out of the composition?
Or accept it can be null?
|
@yschimke - modified to remove the need for the extra field for the last ambient details. |
compose-layout/src/main/java/com/google/android/horologist/compose/ambient/AmbientAware.kt
Outdated
Show resolved
Hide resolved
…pose/ambient/AmbientAware.kt Co-authored-by: Yuri Schimke <yuri@schimke.ee>
WHAT
Provides further guidance on using
AmbientAwareand adds support forAmbientDetailsWHY
Using the
AmbientAwarecomposable changes the behavior of theActivity, so should ideally be used high up in the composable tree. This needs clarifying in the documentation.AmbientDetailsare provided by the system when entering ambient mode, and can be used by the app to make decisions about how to render the UI.HOW
Updates kdoc and adds
AmbientDetailsas a property of theAmbientstate.Checklist 📋