Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview bolded content #1670

Merged
merged 8 commits into from
Sep 11, 2023
Merged

Preview bolded content #1670

merged 8 commits into from
Sep 11, 2023

Conversation

yschimke
Copy link
Collaborator

WHAT

WHY

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested a review from luizgrp September 11, 2023 13:19
@yschimke yschimke marked this pull request as ready for review September 11, 2023 13:19
Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

)
fun datePickerSmallBold() {
screenshotTestRule.setContent(takeScreenshot = true) {
MaterialTheme(typography = MaterialTheme.typography.copy { this.copy(fontWeight = FontWeight.Bold) }) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this can be done via TestHarness as we do with fontScale. I see a fontWeightAdjustment param but haven't tried it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't work on API 30, so I think this is simpler here. I'll add a comment.

@yschimke yschimke merged commit a7f05bd into google:main Sep 11, 2023
@yschimke yschimke deleted the preview_font_sizes branch November 13, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants