Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CompactChip and OutlinedCompactChip #1617

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Improve CompactChip and OutlinedCompactChip #1617

merged 1 commit into from
Aug 30, 2023

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Aug 28, 2023

WHAT

Improve CompactChip and OutlinedCompactChip.

WHY

Address comments from #1579

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp self-assigned this Aug 28, 2023
@luizgrp luizgrp requested a review from yschimke August 28, 2023 08:32
yschimke
yschimke approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@luizgrp luizgrp force-pushed the compmaterial_improvechips branch from 41910b4 to 1a57c4a Compare August 30, 2023 08:03
@luizgrp luizgrp merged commit d29442b into google:main Aug 30, 2023
@luizgrp luizgrp deleted the compmaterial_improvechips branch August 30, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizgrp @yschimke