Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AccountChip #1590

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Add AccountChip #1590

merged 1 commit into from
Aug 19, 2023

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Aug 18, 2023

WHAT

Add AccountChip.

WHY

In order to provide common components.

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp self-assigned this Aug 18, 2023
yschimke
yschimke approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@luizgrp luizgrp merged commit bcfd313 into google:main Aug 19, 2023
@luizgrp luizgrp deleted the authcomp_accountchip branch August 19, 2023 11:23
@luizgrp
Copy link
Member Author

luizgrp commented Aug 21, 2023

cc @LorenzNickel

@luizgrp luizgrp mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizgrp @yschimke