Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve previews and tests of SignedInConfirmationDialog #1585

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Improve previews and tests of SignedInConfirmationDialog #1585

merged 1 commit into from
Aug 16, 2023

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Aug 16, 2023

WHAT

Improve previews and tests of SignedInConfirmationDialog.

WHY

Previously, previews and tests were not working with Dialog component.

HOW

Change previews and tests to use SignedInConfirmationDialog directly.

Checklist 📋

  • [N/A] Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp self-assigned this Aug 16, 2023
@luizgrp luizgrp merged commit 0931050 into google:main Aug 16, 2023
@luizgrp luizgrp deleted the authcomp_signedindialogpreview branch August 16, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizgrp @yschimke