Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CompactChip #1396

Closed
luizgrp opened this issue Jun 14, 2023 · 2 comments
Closed

Implement CompactChip #1396

luizgrp opened this issue Jun 14, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@luizgrp
Copy link
Member

luizgrp commented Jun 14, 2023 •
edited
Loading

Implement CompactChip.

Redlines

Screenshot 2023-06-14 at 15 52 47

Expected output:

  • Implementation in compose-material module, matching the redlines;
  • Implementation should use CompactChip from wear compose material library;
  • Previews in the debug folder for each variant;
  • Snapshot tests for:
    • each variant;
    • text overflow;
    • large font scale (TestHarness(fontScale = 1.18f)));
    • rtl (TestHarness(layoutDirection = LayoutDirection.Rtl)));
    • a11y
@luizgrp luizgrp added the good first issue Good for newcomers label Jun 14, 2023
@luizgrp luizgrp mentioned this issue Jun 14, 2023
Closed
6 tasks
@MohitMandalia
Copy link
Contributor

Can I help in implementing this one?

@luizgrp
Copy link
Member Author

luizgrp commented Aug 7, 2023

@MohitMandalia sure!

MohitMandalia added a commit to MohitMandalia/horologist that referenced this issue Aug 12, 2023
@MohitMandalia @mohitmzendrive
Implement CompactChip Component google#1396
f447e55
MohitMandalia added a commit to MohitMandalia/horologist that referenced this issue Aug 12, 2023
@MohitMandalia @mohitmzendrive
Implement CompactChip Component google#1396
40979dc
@MohitMandalia MohitMandalia mentioned this issue Aug 12, 2023
Merged
4 tasks
MohitMandalia added a commit to MohitMandalia/horologist that referenced this issue Aug 27, 2023
@MohitMandalia
Implement CompactChip Component google#1396
3029cdd
luizgrp pushed a commit that referenced this issue Aug 27, 2023
@MohitMandalia
Implement CompactChip Component #1396 (#1579)
bb689fb
@luizgrp luizgrp closed this as completed Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luizgrp @MohitMandalia