Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Squat Packing's rotate and sum operation and resolved type mismatch issues. #970

Closed
wants to merge 1 commit into from
Closed

Added Squat Packing's rotate and sum operation and resolved type mismatch issues. #970

wants to merge 1 commit into from

Conversation

copybara-service[bot]
Copy link
Contributor

@copybara-service copybara-service bot commented Sep 15, 2024 •
edited
Loading

Added Squat Packing's rotate and sum operation and resolved type mismatch issues.

@copybara-service copybara-service bot changed the title Draft PR: Added Squat Packing's rotate and sum operation and resolved type mismatch issues. Added Squat Packing's rotate and sum operation and resolved type mismatch issues. Sep 20, 2024
@lawrencekhlim
Copy link
Collaborator

I commented out a buggy tensor_ext canonicalization, which makes some tests fail in order to get some squat packing tests to pass. @asraa's code will fix it, and this commit may change as a result.

lawrencekhlim
lawrencekhlim reviewed Sep 21, 2024
View reviewed changes
tests/linalg_to_tensor_ext/float_small_fc_network.mlir
@@ -0,0 +1,47 @@
// This test verifies that a small fully connected network lowers with returning
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Lowers "without" returning an error.

@AlexanderViand-Intel
Copy link
Collaborator

@asraa do you know what the status of this PR is? It looks like it's useful additions (squat packing) that aren't in main right now, but there's clearly also some conflicts/issues?

@j2kun
Copy link
Collaborator

j2kun commented Nov 25, 2024

Asra is out this week. I could try to cherry pick it and resolve the remaining issues, but with the holidays I'm not sure who on the Google side would be around to review.

@AlexanderViand-Intel
Copy link
Collaborator

This isn't urgent, so I'm happy to wait until Asra's back!

@AlexanderViand-Intel
Copy link
Collaborator

Pinging @asraa again on this :)

@j2kun
Copy link
Collaborator

j2kun commented Dec 16, 2024

Asra is out until the new year. I don't think I'll have time to patch and finish this. It may just have to wait.

@asraa
Copy link
Collaborator

asraa commented Jan 15, 2025

Superseeded by #1269

@asraa asraa closed this Jan 15, 2025
@asraa asraa mentioned this pull request Jan 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawrencekhlim lawrencekhlim lawrencekhlim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lawrencekhlim @AlexanderViand-Intel @j2kun @asraa