Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a verifier for bgv.rotate and corresponding test (#287) #295

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add a verifier for bgv.rotate and corresponding test (#287) #295

merged 1 commit into from
Nov 30, 2023

Conversation

Maokami
Copy link
Collaborator

@Maokami Maokami commented Nov 29, 2023

  • add verifier for bgv.rotate
  • add simple expected-error-test for bgv.rotate

j2kun
j2kun approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@j2kun j2kun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution! I added two comments for optional improvements. If you don't have time for those I can go in and fix them after it merges.

If you do make those changes, please squash all your changes into one commit before we merge.

tests/bgv/verifier.mlir Outdated Show resolved Hide resolved
lib/Dialect/BGV/IR/BGVDialect.cpp Outdated Show resolved Hide resolved
@Maokami Maokami force-pushed the bgv-verifier-rotate branch from 697ecc0 to 9b14d7a Compare November 30, 2023 03:03
@Maokami Maokami force-pushed the bgv-verifier-rotate branch from cfea781 to 04fb0e2 Compare November 30, 2023 03:11
@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Nov 30, 2023
@j2kun j2kun merged commit 5b025b1 into google:main Nov 30, 2023
7 checks passed
@Maokami Maokami deleted the bgv-verifier-rotate branch December 1, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j2kun j2kun j2kun approved these changes

Assignees
No one assigned
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maokami @j2kun