Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tfhe-rs tests in CI #265

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Run tfhe-rs tests in CI #265

merged 1 commit into from
Nov 17, 2023

Conversation

j2kun
Copy link
Collaborator

@j2kun j2kun commented Nov 17, 2023

Fixes #248

asraa
asraa approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally sure why rust-toolchain action is mising the toolchain when it should be optional... maybe it needs a version bump

@j2kun
Copy link
Collaborator Author

j2kun commented Nov 17, 2023

Not totally sure why rust-toolchain action is mising the toolchain when it should be optional... maybe it needs a version bump

It's because I pinned to a commit hash. If you use @stable it will read that and infer the rust toolchain version.

@asraa asraa added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Nov 17, 2023
@copybara-service copybara-service bot merged commit 74e7a57 into google:main Nov 17, 2023
@j2kun j2kun deleted the rust-ci branch December 12, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asraa asraa asraa approved these changes

Assignees
No one assigned
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tfhe_rust: add end-to-end testing to Github CI
2 participants
@j2kun @asraa