Add a verifier for bgv.rotate and corresponding test (#287)

google · Nov 29, 2023 · 1657451 · 1657451
1 parent 649b4f6
commit 1657451
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/include/Dialect/BGV/IR/BGVOps.td b/include/Dialect/BGV/IR/BGVOps.td
@@ -82,6 +82,8 @@ def BGV_Rotate : BGV_Op<"rotate", [SameOperandsAndResultRings]> {
   let results = (outs
     Ciphertext:$output
   );
+
+  let hasVerifier = 1;
 }
 
 def BGV_Negate : BGV_Op<"negate", [SameOperandsAndResultType]> {

diff --git a/lib/Dialect/BGV/IR/BGVDialect.cpp b/lib/Dialect/BGV/IR/BGVDialect.cpp
@@ -53,6 +53,17 @@ LogicalResult MulOp::verify() {
   }
   return success();
 }
+LogicalResult Rotate::verify() {
+  auto x = this->getX().getType();
+  if (x.getDim() != 2) {
+    return this->emitOpError() << "x.dim == 2 does not hold";
+  }
+  auto out = this->getOutput().getType();
+  if (out.getDim() != 2) {
+    return this->emitOpError() << "output.dim == 2 does not hold";
+  }
+  return success();
+}
 
 LogicalResult Relinearize::verify() {
   auto x = this->getX().getType();

diff --git a/tests/bgv/verifier.mlir b/tests/bgv/verifier.mlir
@@ -0,0 +1,13 @@
+// RUN: heir-opt --verify-diagnostics --split-input-file %s
+
+#my_poly = #polynomial.polynomial<1 + x**1024>
+#ring1 = #polynomial.ring<cmod=463187969, ideal=#my_poly>
+#ring2 = #polynomial.ring<cmod=33538049, ideal=#my_poly>
+#rings = #bgv.rings<#ring1, #ring2>
+
+func.func @test_input_dimension_error(%input: !bgv.ciphertext<rings=#rings, dim=3>) {
+  // expected-error@+1 {{x.dim == 2 does not hold}}
+  %out = bgv.rotate (%input) {offset = 4} : (!bgv.ciphertext<rings=#rings, dim=3>) -> !bgv.ciphertext<rings=#rings>
+
+  return
+}