Alternative way to get AssertionError instance in #2012
Conversation
com.google.common.util.concurrent.GeneratedMonitorTest, since public AssertionError(String message, Throwable cause) does not exist in Java 6 yet.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
Our current policy is that Guava runs with Java 6+ but that it may require a newer version to build. I would not mind if we fixed this occurrence up, but we currently have no way to prevent future violations. Animal Sniffer, which we use for Java 6 enforcement, seems to work only on the main compile, not the test compile. (I was able to run it only by telling Maven that our test sources were normal sources and that all of our test-only deps were normal deps.) If anyone can figure out a way to run it on the test sources, we'd probably be interested. [edit: Animal Sniffer starts checking test code in 1.19.] (Also, see the CLA warning above. If it's something you'd rather not sign, I can submit my own workaround. (This is a problem we've had to confront in ours tests previously where it affected GWT compatibility.)) |
|
I thought I have signed the cla, but only after I created the pull request. |
|
CLAs look good, thanks! |
|
I guess that the bot just takes a little while to run. Or maybe someone needs to come and say the magic work "CLA?" Anyway, looks good now. Thanks! |
|
I think the bot might just require someone (possibly the author?) to comment on the pull request again after the CLA has been signed for it to check again. |
For the places I found, I added 0L. I ignored the abstract classes and enums. There are might be other places, whose super class implements the Serializable, and the Subclass does not have its own serialVersionUID. Also, in the code base, some of the serialVersionID uses 0L, 1L, etc., while some others use random numbers. Personally, I think the increment number is better, and it might be good if everything could be unified.
…til.concurrent.GeneratedMonitorTest, since public AssertionError(String message, Throwable cause) does not exist in Java 6 yet. Pull request from Pingsan: #2012 ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=89416149
|
Done in 9131ddb It looks like we got the commit metadata wrong -- sorry. |
Alternative way to get AssertionError instance in com.google.common.util.concurrent.GeneratedMonitorTest, since
public AssertionError(String message, Throwable cause)
does not exist in Java 6 yet.