[Code health] Upgrade ktfmt-gradle and apply latest ktfmt AS plugin to reduce formatting deltas between the two #2456
+378
−403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
483f2dd to
7f16067
Compare
|
@sufyanAbbasi PTAL? Note the churn in the commit log is because I was trying to isolate deltas as repro for facebook/ktfmt#444, and the get the two formatter plugins to a stable state on all but one delta. |
shobhitagarwal1612
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades ktfmt-gradle plugin to latest (0.18.0) and applies both ktfmt-gradle and AS ktfmt plugin until deltas are stable, with one exception in
Config.ktwhich gets updated when running the AS plugin.Towards #2457.
Repro described in facebook/ktfmt#444 in commit log.