Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process info #59

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Add process info #59

merged 1 commit into from
Feb 28, 2018

Conversation

rakyll
Copy link
Member

@rakyll rakyll commented Oct 22, 2017

Example output:

$ gops $PID
threads: 14
memory usage: 0.090%
cpu usage: 0.088%
username: jbd
cmd+args: /Users/jbd/bin/gocode -s -sock unix -addr 127.0.0.1:37373

Fixes #58.

@rakyll rakyll requested a review from odeke-em October 22, 2017 18:58
Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work @rakyll! I've left some minor changes. Also perhaps could we also update the README.md file?

main.go Outdated
)

const helpText = `Usage: gops is a tool to list and diagnose Go processes.

go [cmd] ...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/go /gops /

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

main.go Outdated
)

const helpText = `Usage: gops is a tool to list and diagnose Go processes.

go [cmd] ...
go <pid> # displays process info
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto about s/go /gops /

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

main.go Outdated
@@ -46,12 +50,17 @@ func main() {
}

cmd := os.Args[1]

// see it is a PID
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: see if it is a PID

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@rakyll rakyll force-pushed the processinfo branch 2 times, most recently from ceed334 to 92413e6 Compare February 28, 2018 03:07
@rakyll
Copy link
Member Author

rakyll commented Feb 28, 2018

PTAL, all addressed.

Example output:

$ gops <pid>
threads:      14
memory usage: 0.090%
cpu usage:    0.088%
username:     jbd
cmd+args:     /Users/jbd/bin/gocode -s -sock unix -addr 127.0.0.1:37373

Fixes google#58.
@rakyll rakyll dismissed odeke-em’s stale review February 28, 2018 03:41

All addressed.

@rakyll rakyll merged commit 09ff00a into google:master Feb 28, 2018
@rakyll rakyll deleted the processinfo branch February 28, 2018 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants