Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use unbuffered channels #128

Closed
wants to merge 1 commit into from
+12 −8
Closed

use unbuffered channels #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions goprocess/gp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,15 @@ func FindAll() []P {
return nil
}

input := make(chan ps.Process, len(pss))
output := make(chan P, len(pss))
input := make(chan ps.Process)
output := make(chan P)

for _, ps := range pss {
input <- ps
}
close(input)
go func() {
for _, ps := range pss {
input <- ps
}
close(input)
}()

var wg sync.WaitGroup
wg.Add(concurrencyLimit) // used to wait for workers to be finished
Expand Down Expand Up @@ -70,8 +72,10 @@ func FindAll() []P {
}
}()
}
wg.Wait() // wait until all workers are finished
close(output) // no more results to be waited for
go func() {
wg.Wait() // wait until all workers are finished
close(output) // no more results to be waited for
}()

var results []P
for p := range output {
Expand Down