Fix the worker concurrency model #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit the number of concurrent workers by starting a fixed number of goroutines and providing work by an input channel. Fixes google#123
|
Thanks for the quick review! |
|
channel output does not have to be buffered of len of all the processes. #128 fixes this. |
Closed
yarcat
added a commit
to yarcat/gops
that referenced
this pull request
Sep 9, 2020
This solution is a bit more idiomatic and resonates with "Don't communicate by sharing memory, share memory by communicating." Go proverb [^1]. Similar approach to use buffered channel as a semaphore to limit throughput is discussed in Effective Go [^2]. [^1]: https://go-proverbs.github.io/ [^2]: https://golang.org/doc/effective_go.html#channels
yarcat
added a commit
to yarcat/gops
that referenced
this pull request
Sep 9, 2020
This solution is a bit more idiomatic and resonates with "Don't communicate by sharing memory, share memory by communicating." Go proverb [^1]. Similar approach to use buffered channel as a semaphore to limit throughput is discussed in Effective Go [^2]. [^1]: https://go-proverbs.github.io/ [^2]: https://golang.org/doc/effective_go.html#channels
yarcat
added a commit
to yarcat/gops
that referenced
this pull request
Sep 10, 2020
This solution is a bit more idiomatic and resonates with "Don't communicate by sharing memory, share memory by communicating." Go proverb[^1]. Similar approach to use buffered channel as a semaphore to limit throughput is discussed in Effective Go[^2]. [^1]: https://go-proverbs.github.io/ [^2]: https://golang.org/doc/effective_go.html#channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the number of concurrent workers by starting a fixed number of goroutines and providing work by an input channel.
Fixes #123