-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppVeyor MinGW-w64 test build #870
Conversation
appveyor.yml
Outdated
- Debug | ||
- Release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the release build was commented out because of slow builds on appveyor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disabled this configuration when created appveyor.yml. Now I think it's better to check both configurations
29bd7d7
to
c73f11e
Compare
c73f11e
to
30f15c9
Compare
Can we get back to this? May be useful for issue detection |
This is old and needs to be rebased |
30f15c9
to
f2f5d86
Compare
Rebased |
One thing I noticed that this takes longer to build on AppVeyor, take a look at https://ci.appveyor.com/project/GoogleTestAppVeyor/googletest/build/522. Why is this taking so long? |
I can disable |
Lets try and see .. this is useful but we cant be waiting this long each time |
f2f5d86
to
b6caac4
Compare
Apveyor Build Failed |
e55fbe5
to
afcce71
Compare
Fixed |
This is sadly out of date now and there are merge conflicts. |
3670960
to
5dde668
Compare
Done |
@gennadiycivil Can you review this PR? I rebase this branch every day for this |
Sorry for the delay. |
- Toolset: v120 | ||
- Toolset: v110 | ||
- Toolset: v100 | ||
- compiler: msvc-14-seh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we are swtiching from matrix to actually spelling out which build are going to go
Why?
Cant we just one more toolset? /I am not very familiar with AppVeyor so forgive me if this is silly/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refactored created by me appveyor.yml
because of old file use platform
variable, but it not useful for MinGW.
I just used my file from google/benchmark google/benchmark@3336ea0
looks good to me. I am a little concerned with additional execution time but we shall see. |
It's almost same: |
Awesome, totally worth it |
But note that the Mingw builds don't include Google Test's unit tests, what makes them so fast. |
Tests disabled for mingw64
AppVeyor should pass after merging PR #856