-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add insecure flag to push and pull #634
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
==========================================
+ Coverage 76.29% 76.53% +0.24%
==========================================
Files 101 101
Lines 4412 4483 +71
==========================================
+ Hits 3366 3431 +65
Misses 636 636
- Partials 410 416 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change! Small comment otherwise looks good.
You'll want to run
I don't see any problem with what you've done here, that looks like what I'd have done. |
What this PR does / why we need it:
Adds the ability to push and pull from insecure registries to the crane cmd.
The flag also had to be added to a few other subcommands like export, append and etc.
Which issue this PR fixes:
fixes #633
Special notes for your reviewer:
I wasn't sure if it's ok to change the handler map in the validate subcommand without any prior discussions, so I just added the options argument to
makeTarball
as a temporary fix so we don't have failing tests.Let me know if it's ok to change the handler map and also what do you think is a good approach to change it.
https://github.com/google/go-containerregistry/pull/634/files#diff-67c9d71faf9a3b5faa49b6f666170f54R72