Remove unused empty Options structs #278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of packages included empty
FooOptions
structs which we could use to allow callers to pass optional options to the methods.In practice, these didn't add anything and just added a wart. Users had to pass
foo.FooOptions{}
, or&foo.FooOptions{}
, ornil
to lots of random methods. We weren't consistent about whether options should be accepted as a pointer or not, or whether absence of options should be expressed as a pointer to an empty struct, ornil
.If these methods want to add options in the future, they should do so using functional options, where we can add more options to the method args directly without breaking existing callers.