Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to reduce spammy logs from external cred helpers #1283

Closed
wants to merge 3 commits into from

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Feb 9, 2022

No description provided.

@imjasonh
Copy link
Collaborator Author

imjasonh commented Feb 9, 2022

I'm not sure why ko with ko-build/ko#581 logs pkg/v1/google.Keychain errors, since AFAIK logs.Debug is discarded by default, and I don't see where ko changes that, if anywhere.

I'll need to look closer, ideas welcome.

@imjasonh
Copy link
Collaborator Author

imjasonh commented Feb 9, 2022

lol nevermind this doesn't work anyway

pkg/authn/keychain.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #1283 (7653dc2) into main (d3202cc) will decrease coverage by 0.00%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
- Coverage   74.03%   74.03%   -0.01%     
==========================================
  Files         112      112              
  Lines        8374     8391      +17     
==========================================
+ Hits         6200     6212      +12     
- Misses       1571     1575       +4     
- Partials      603      604       +1     
Impacted Files Coverage Δ
pkg/authn/keychain.go 85.36% <82.35%> (-0.79%) ⬇️
pkg/v1/remote/multi_write.go 62.92% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3202cc...7653dc2. Read the comment docs.

@imjasonh
Copy link
Collaborator Author

imjasonh commented Feb 9, 2022

Closing in favor of hopefully making ecr-login's logging more configurable: awslabs/amazon-ecr-credential-helper#309

@imjasonh imjasonh closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants