Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub/mqttpubsub: add mqtt pubsub support #2751

Closed
wants to merge 11 commits into from

Conversation

filinvadim
Copy link

@filinvadim filinvadim commented Feb 25, 2020

Fixes #1466

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Cannot accept contribution until Google CLA is signed. label Feb 25, 2020
@filinvadim
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@filinvadim
Copy link
Author

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Google CLA has been signed! and removed cla: no Cannot accept contribution until Google CLA is signed. labels Feb 25, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@eliben
Copy link
Member

eliben commented Feb 25, 2020

Thanks for the contribution, @filinvadim

I'll point to a comment by @jba made in the issue: #1466 (comment)

We'd like to see additional drivers get considerable use outside the main go-cloud repo before considering taking them in.

@filinvadim
Copy link
Author

@eliben it was unclear if @jba comment is mandatory or optional

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #2751 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2751   +/-   ##
=======================================
  Coverage   67.79%   67.79%           
=======================================
  Files         117      117           
  Lines       13590    13590           
=======================================
  Hits         9214     9214           
  Misses       3686     3686           
  Partials      690      690

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c374d0...057d22f. Read the comment docs.

@filinvadim filinvadim force-pushed the master branch 4 times, most recently from 843f0d2 to 8d8c7d3 Compare February 26, 2020 23:15
@filinvadim
Copy link
Author

filinvadim commented Feb 27, 2020

Close PR please if it's not needed. @eliben?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub: add MQTT driver
3 participants