Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iansui: 1.011 added #9022

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Iansui: 1.011 added #9022

merged 1 commit into from
Jan 31, 2025

Conversation

aaronbell
Copy link
Collaborator

Taken from the upstream repo https://github.com/ButTaiwan/iansui at commit https://github.com/ButTaiwan/iansui/tree/a66e7fe5bc492b358d8dc916f359157133a1d23c

Changelist:
Fonts are now building from .glyphspackage source
Vertical metrics updated to follow new guidance
Three characters added (鿬鿫䴉) and 1 updated (魔)
Other minor outline changes implemented to resolve issues in the source (which may cause small downstream diffs)

Fonts are now building from .glyphspackage source
Vertical metrics updated to follow new guidance
Three characters added (鿬鿫䴉) and 1 updated (魔)
Copy link

FontBakery report

fontbakery version: 0.13.1

Check results

[29] Iansui-Regular.ttf
🔥 FAIL Ensure the font supports case swapping for all its glyphs. case_mapping
  • 🔥 FAIL

    The following glyphs lack their case-swapping counterparts:

Glyph present in the font Missing case-swapping counterpart
U+014B: LATIN SMALL LETTER ENG U+014A: LATIN CAPITAL LETTER ENG
U+01FD: LATIN SMALL LETTER AE WITH ACUTE U+01FC: LATIN CAPITAL LETTER AE WITH ACUTE
U+0254: LATIN SMALL LETTER OPEN O U+0186: LATIN CAPITAL LETTER OPEN O
U+0259: LATIN SMALL LETTER SCHWA U+018F: LATIN CAPITAL LETTER SCHWA
U+025B: LATIN SMALL LETTER OPEN E U+0190: LATIN CAPITAL LETTER OPEN E
U+026A: LATIN LETTER SMALL CAPITAL I U+A7AE: LATIN CAPITAL LETTER SMALL CAPITAL I
U+0275: LATIN SMALL LETTER BARRED O U+019F: LATIN CAPITAL LETTER O WITH MIDDLE TILDE
U+0283: LATIN SMALL LETTER ESH U+01A9: LATIN CAPITAL LETTER ESH
U+028A: LATIN SMALL LETTER UPSILON U+01B1: LATIN CAPITAL LETTER UPSILON
U+028C: LATIN SMALL LETTER TURNED V U+0245: LATIN CAPITAL LETTER TURNED V
U+0292: LATIN SMALL LETTER EZH U+01B7: LATIN CAPITAL LETTER EZH
U+03DB: GREEK SMALL LETTER STIGMA U+03DA: GREEK LETTER STIGMA
U+1E37: LATIN SMALL LETTER L WITH DOT BELOW U+1E36: LATIN CAPITAL LETTER L WITH DOT BELOW
U+1E43: LATIN SMALL LETTER M WITH DOT BELOW U+1E42: LATIN CAPITAL LETTER M WITH DOT BELOW
U+1E47: LATIN SMALL LETTER N WITH DOT BELOW U+1E46: LATIN CAPITAL LETTER N WITH DOT BELOW
U+1F70: GREEK SMALL LETTER ALPHA WITH VARIA U+1FBA: GREEK CAPITAL LETTER ALPHA WITH VARIA
U+1F71: GREEK SMALL LETTER ALPHA WITH OXIA U+1FBB: GREEK CAPITAL LETTER ALPHA WITH OXIA
U+1F72: GREEK SMALL LETTER EPSILON WITH VARIA U+1FC8: GREEK CAPITAL LETTER EPSILON WITH VARIA
U+1F73: GREEK SMALL LETTER EPSILON WITH OXIA U+1FC9: GREEK CAPITAL LETTER EPSILON WITH OXIA
[code: missing-case-counterparts]
🔥 FAIL Ensure glyphs do not have components which are themselves components. nested_components
  • 🔥 FAIL

    The following glyphs have components which themselves are component glyphs:

  • OOpoj_gravecomb
  • OOpoj_acutecomb
  • OOpoj_hungarumlautcomb
  • OOpoj_circumflexcomb
  • OOpoj_caroncomb
  • OOpoj_brevecomb
  • OOpoj_macroncomb
  • OOpoj_verticallineabovecomb
  • oopoj_gravecomb
  • oopoj_acutecomb and 6 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-nested-components]
🔥 FAIL Ensure smart dropout control is enabled in "prep" table instructions. smart_dropout
  • 🔥 FAIL

    The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script.


    [code: lacks-smart-dropout]
🔥 FAIL METADATA.pb font.name and font.full_name fields match the values declared on the name table? googlefonts/metadata/nameid/family_and_full_names
  • 🔥 FAIL

    METADATA.pb: Fullname "Iansui Regular" does not match name table entry "芫荽 Regular"!


    [code: fullname-mismatch]
🔥 FAIL Check family name for GF Guide compliance. googlefonts/family_name_compliance
  • 🔥 FAIL

    "芫荽" contains the following characters which are not allowed: "芫荽".


    [code: forbidden-characters]

  • 🔥 FAIL

    "芫荽" doesn't start with an uppercase letter.


    [code: starts-with-not-uppercase]

🔥 FAIL Copyright notices match canonical pattern in fonts googlefonts/font_copyright
  • 🔥 FAIL

    Copyright notices differ between name table entries and METADATA.pb.The following copyright values were found:

- Copyright 2025 The Iansui Project Authors (https://github.com/ButTaiwan/iansui): Name Table entry

- Copyright 2022 The Iansui Project Authors (https://github.com/ButTaiwan/iansui).: METADATA.pb

[code: mismatch]

🔥 FAIL Check font follows the Google Fonts CJK vertical metric schema googlefonts/cjk_vertical_metrics
  • 🔥 FAIL

    OS/2 fsSelection bit 7 must be disabled


    [code: bad-fselection-bit7]

  • 🔥 FAIL

    OS/2.sTypoAscender is "940" it should be 880


    [code: bad-OS/2.sTypoAscender]

  • 🔥 FAIL

    OS/2.sTypoDescender is "-180" it should be -120


    [code: bad-OS/2.sTypoDescender]

  • 🔥 FAIL

    hhea.ascent must match OS/2.usWinAscent


    [code: ascent-mismatch]

  • 🔥 FAIL

    hhea.descent must match absolute value of OS/2.usWinDescent


    [code: descent-mismatch]

🔥 FAIL Check font names are correct googlefonts/font_names
  • 🔥 FAIL

    Font names are incorrect:

nameID current expected
Family Name Iansui Iansui
Subfamily Name Regular Regular
Full Name Iansui Regular Iansui Regular
Postscript Name Iansui-Regular Iansui-Regular
Typographic Family Name Iansui N/A
Typographic Subfamily Name Regular N/A
[code: bad-names]
⚠️ WARN Check mark characters are in GDEF mark glyph class. opentype/gdef_mark_chars
  • ⚠️ WARN

    The following mark characters could be in the GDEF mark glyph class:
    cedilla (U+0327), ring (U+030A), tilde (U+0303), underscore (U+0332) and uni20DE (U+20DE)


    [code: mark-chars]
⚠️ WARN Does the font contain chws and vchw features? cjk_chws_feature
⚠️ WARN Check if each glyph has the recommended amount of contours. contour_count
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: uni2504	Contours detected: 6	Expected: 3
  • Glyph name: uni2505 Contours detected: 6 Expected: 3

  • Glyph name: uni2506 Contours detected: 6 Expected: 3

  • Glyph name: uni2507 Contours detected: 6 Expected: 3

  • Glyph name: uni2508 Contours detected: 6 Expected: 4

  • Glyph name: uni2509 Contours detected: 6 Expected: 4

  • Glyph name: uni250A Contours detected: 6 Expected: 4

  • Glyph name: uni250B Contours detected: 6 Expected: 4

  • Glyph name: uni25CC Contours detected: 24 Expected: 16 or 12

  • Glyph name: uni2504 Contours detected: 6 Expected: 3

  • 8 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Ensure files are not too large. file_size
  • ⚠️ WARN

    Font file is 9.0Mb; ideally it should be less than 1.0Mb


    [code: large-font]
⚠️ WARN Are there caret positions declared for every ligature? ligature_carets
  • ⚠️ WARN

    This font lacks caret position values for ligature glyphs on its GDEF table.


    [code: lacks-caret-pos]
⚠️ WARN Check math signs have the same width. math_signs_width
  • ⚠️ WARN

    The most common width is 1000 among a set of 21 math glyphs.
    The following math glyphs have a different width, though:

Width = 600: plusminus, less, asciitilde, divide, greater, multiply, plus, equal

Width = 590: logicalnot

Width = 350: minus

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs unreachable_glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- a_prolonged_rukata

- circle.alt

- exclamdbl.slant

- filledbox.blackBox

- filledbox.roundBlackBox

- kosmallhira

- kosmallkata

- male.alt

- one_eighthan.paren

- one_fivehan.paren

- 63 more.

Use -F or --full-lists to disable shortening of long lists.

[code: unreachable-glyphs]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets. googlefonts/article/images
  • ⚠️ WARN

    Article page is too short!


    [code: length-requirements-not-met]
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog? googlefonts/metadata/designer_profiles
  • ⚠️ WARN

    It seems that But Ko is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]
⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, math, tifinagh, cherokee
  • U+0305 COMBINING OVERLINE: try adding one of: coptic, gothic, elbasan, glagolitic, math
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: duployan, old-permic, canadian-aboriginal, malayalam, tifinagh, todhri, coptic, syriac, math, hebrew, tai-le
  • U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+030D COMBINING VERTICAL LINE ABOVE: try adding sunuwar
  • U+0327 COMBINING CEDILLA: try adding math 5657 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-hongkong, latin, latin-ext, menu, symbols2

[code: unreachable-subsetting]
⚠️ WARN Check copyright namerecords match license file. googlefonts/name/license
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. soft_dotted
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ j̀ j́ j̃ j̄ j̈ ɨ̀ ɨ́ ɨ̂ ɨ̃ ɨ̄ ɨ̈ ɨ̋ ɨ̌ ɨ̧̀ ɨ̧́ ɨ̧̂ ɨ̧̌

The dot of soft dotted characters should disappear in other cases, for example: i̅ i̇ ị̅ ị̇ ị̊ ị̋ ị̍ i̧̅ i̧̇ i̧̊ i̧̋ i̧̍ į̅ į̇ į̊ į̋ į̍ i̲̅ i̲̇ i̲̊

Your font does not cover the following languages that require the soft-dotted feature: Abua (Latn, 25,000 speakers), Lithuanian (Latn, 2,357,094 speakers), Keliko (Latn, 63,000 speakers), Western Krahn (Latn, 97,800 speakers), Lugbara (Latn, 2,200,000 speakers), Vute (Latn, 21,000 speakers), Dutch (Latn, 31,709,104 speakers), Longto (Latn, 5,000 speakers), South Central Banda (Latn, 244,000 speakers), Zapotec (Latn, 490,000 speakers), Ekpeye (Latn, 226,000 speakers), Cicipu (Latn, 44,000 speakers), Ejagham (Latn, 120,000 speakers), Avokaya (Latn, 100,000 speakers), Nateni (Latn, 100,000 speakers), Mundani (Latn, 34,000 speakers), Kaska (Latn, 125 speakers), Fur (Latn, 1,230,163 speakers), Ikwere (Latn, 717,000 speakers), Northern Tutchone (Latn, 85 speakers), Bafut (Latn, 158,146 speakers), Yala (Latn, 200,000 speakers), Heiltsuk (Latn, 300 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Sar (Latn, 500,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Southern Kisi (Latn, 360,000 speakers), Koonzime (Latn, 40,000 speakers), Makaa (Latn, 221,000 speakers), Nzakara (Latn, 50,000 speakers), Ma’di (Latn, 584,000 speakers), Aghem (Latn, 38,843 speakers), Southern Tutchone (Latn, 65 speakers), Bete-Bendi (Latn, 100,000 speakers), Dan (Latn, 1,099,244 speakers), Gulay (Latn, 250,478 speakers), Kom (Latn, 360,685 speakers), Mango (Latn, 77,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Igbo (Latn, 27,823,640 speakers), Navajo (Latn, 166,319 speakers), Dii (Latn, 71,000 speakers), Han (Latn, 6 speakers), Ebira (Latn, 2,200,000 speakers), Mfumte (Latn, 79,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Basaa (Latn, 332,940 speakers), Teke-Ebo (Latn, 260,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers).

[code: soft-dotted]
⚠️ WARN Do outlines contain any jaggy segments? outline_jaggy_segments
  • ⚠️ WARN

    The following glyphs have jaggy segments:

* W.half: B<<118.5,297.5>-<126.0,210.0>-<135.0,107.0>>/B<<135.0,107.0>-<149.0,242.0>-<162.5,364.5>> = 10.91436469987018

* W.half: B<<332.5,365.5>-<348.0,240.0>-<364.0,104.0>>/B<<364.0,104.0>-<377.0,240.0>-<388.0,355.0>> = 12.170049399905247

* eight (U+0038): B<<375.0,480.0>-<423.0,515.0>-<467.0,550.0>>/B<<467.0,550.0>-<465.0,549.0>-<459.0,549.0>> = 11.935602543267397

* eight.box: B<<569.5,467.0>-<613.0,493.0>-<652.0,522.0>>/B<<652.0,522.0>-<650.0,521.0>-<646.0,521.0>> = 10.06906269888942

* eight.box: B<<673.0,547.0>-<673.0,542.0>-<670.0,537.0>>/B<<670.0,537.0>-<672.0,539.0>-<679.0,544.5>> = 14.036243467926457

* eight.half: B<<326.5,479.5>-<375.0,515.0>-<419.0,550.0>>/B<<419.0,550.0>-<417.0,549.0>-<411.0,549.0>> = 11.935602543267397

* eight.roundBox: B<<569.5,467.0>-<613.0,493.0>-<652.0,522.0>>/B<<652.0,522.0>-<650.0,521.0>-<646.0,521.0>> = 10.06906269888942

* eight.roundBox: B<<673.0,547.0>-<673.0,542.0>-<670.0,537.0>>/B<<670.0,537.0>-<672.0,539.0>-<679.0,544.5>> = 14.036243467926457

* m.half: B<<82.0,432.0>-<81.0,420.0>-<80.0,406.0>>/B<<80.0,406.0>-<91.0,441.0>-<114.0,464.0>> = 13.361571643307292

* one_ninehan.paren: B<<869.0,104.0>-<868.0,83.0>-<865.0,66.0>>/B<<865.0,66.0>-<895.0,135.0>-<909.0,208.5>> = 13.490585874510721

* 388 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines? outline_semi_vertical
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* T (U+0054): L<<251.0,107.0>--<252.0,632.0>>

* T (U+0054): L<<322.0,636.0>--<323.0,106.0>>

* T.blackBox: L<<458.0,578.0>--<457.0,169.0>>

* T.blackBox: L<<546.0,168.0>--<545.0,583.0>>

* T.half: L<<213.0,107.0>--<214.0,630.0>>

* T.half: L<<284.0,635.0>--<285.0,106.0>>

* T.roundBox: L<<472.0,169.0>--<473.0,594.0>>

* T.roundBox: L<<530.0,597.0>--<531.0,168.0>>

* T_B: L<<224.0,107.0>--<225.0,630.0>>

* T_B: L<<294.0,635.0>--<295.0,106.0>>

* 19743 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]
⚠️ WARN Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 1: flag = 0x0A - Use grayscale rendering - Use smoothing along multiple axes with ClearType® PPM <= 2: flag = 0x07 - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
  • ⚠️ WARN

    The gasp table has a range of 1 that may be unneccessary.


    [code: non-ffff-range]

  • ⚠️ WARN

    The gasp table has a range of 2 that may be unneccessary.


    [code: non-ffff-range]

⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths superfamily/list
  • ℹ️ INFO

    ofl/iansui


    [code: family-path]
ℹ️ INFO Show hinting filesize impact. hinting_impact
  • ℹ️ INFO

    Hinting filesize impact:

ofl/iansui/Iansui-Regular.ttf
Dehinted Size 9.0Mb
Hinted Size 9.0Mb
Increase 8 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables? required_tables
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- BASE

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.011']


    [code: version-not-detected]
[2] Family checks
🔥 FAIL Directory name in GFonts repo structure must match NameID 1 of the regular. googlefonts/repo/dirname_matches_nameid_1
  • 🔥 FAIL

    Family name on the name table ('芫荽') does not match directory name in the repo structure ('iansui'). Expected '芫荽'.


    [code: mismatch]
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 9 16 62 6 143 0
0% 0% 4% 7% 26% 3% 61% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e m4rc1e merged commit d305b23 into main Jan 31, 2025
9 checks passed
@m4rc1e m4rc1e deleted the iansui_update branch January 31, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Font Upgrade II CJK Chinese, Japanese, Korean scripts
Projects
Status: In Sandbox
Development

Successfully merging this pull request may close these issues.

2 participants