Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] fix Miri flag passing #6583

Closed
wants to merge 1 commit into from
Closed

[Rust] fix Miri flag passing #6583

wants to merge 1 commit into from

Conversation

RalfJung
Copy link

Miri flag passing changed a while ago and the compatibility code is scheduled to be removed soon. This ports the test suite to the new way of passing flags to Miri.

Cc @CasperN

@google-cla
Copy link

google-cla bot commented Apr 20, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@RalfJung
Copy link
Author

RalfJung commented Apr 20, 2021

I'm sorry but signing a CLA is too much effort for such a one-line drive-by fix.^^ And moreover it looks like that requires a Google account, which I am not willing to create as it asks for personal data [phone numbers] that I do not want to share.
@CasperN feel free to re-submit this PR as your own if that helps.

@CasperN
Copy link
Collaborator

CasperN commented Apr 26, 2021

yea I'll resubmit this PR, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants