[C#, Java, C++] Fixes issue #5399 by always including namespaces #5404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since changing the generated C# method names from
GetProperty<T>()
to justProperty<T>()
, there is the potential to more easily generate method names that conflict with class or struct names in the same namespace. This PR modifiesBaseGenerator::WrapInNameSpace()
to stops omitting the current namespace and always be explicit.It appears that the same method applies to Java and C++ as well, so those languages are also affected by this change.
A sample schema and sample code that demonstrates the naming conflict can be found here:
https://gist.github.com/lux/af8ca8ebe333c27106b00e13328e7c8e#file-notes-md