Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base type safety in C#. Clear FlatBufferBuilder in C#. #241

Merged
3 commits merged into from
Jul 29, 2015
Merged

Base type safety in C#. Clear FlatBufferBuilder in C#. #241

3 commits merged into from
Jul 29, 2015

Conversation

RevenantX
Copy link
Contributor

Hi! I added basic offset safety in C# binding. And method that allows reset FlatBufferBuilder state.
int offsets replaced by Offset<T> for structs and tables, StringOffset for strings and VectorOffset for vectors.

@ghost
Copy link

ghost commented Jul 29, 2015

This looks great!

Did you run any performance tests to see if the small structs are close to the speed of ints? They should be, but it be nice to know for sure.

Did you run generate code for Java to ensure nothing has changed there?

@RevenantX
Copy link
Contributor Author

Did you run generate code for Java to ensure nothing has changed there?

Yes. In Java nothing changed.

Did you run any performance tests to see if the small structs are close to the speed of ints? They should be, but it be nice to know for sure.

No. Maybe speed difference exists. But very liitle.

@ghost
Copy link

ghost commented Jul 29, 2015

This will be a breaking change for C# users, but it will be for a good cause :)

ghost pushed a commit that referenced this pull request Jul 29, 2015
[BREAKING CHANGE] Base type safety in C#. Clear FlatBufferBuilder in C#.
@ghost ghost merged commit 9a30d3d into google:master Jul 29, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant