Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag --incompatible_config_setting_private_default_visibility will break FlatBuffers in Bazel 7.0 #7664

Closed
keertk opened this issue Nov 23, 2022 · 2 comments · Fixed by #7691
Closed

Flag --incompatible_config_setting_private_default_visibility will break FlatBuffers in Bazel 7.0 #7664

keertk opened this issue Nov 23, 2022 · 2 comments · Fixed by #7691

Comments

@keertk
Copy link
Member

keertk commented Nov 23, 2022 •
edited
Loading

Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking FlatBuffers. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#12933.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.
@keertk keertk mentioned this issue Nov 23, 2022
Open
@keertk keertk changed the title Flag --incompatible_config_setting_private_default_visibility will break FlatBuffers in a future Bazel release Flag --incompatible_config_setting_private_default_visibility will break FlatBuffers in Bazel 7.0 Nov 29, 2022
@dbaileychess
Copy link
Collaborator

@jkuszmaul Mind taking a look at this?

@jkuszmaul
Copy link
Contributor

I'll take a look this weekend.

jkuszmaul added a commit to jkuszmaul/flatbuffers that referenced this issue Dec 3, 2022
@jkuszmaul
Upgrade rules_go for Bazel 7.0 support
d1dcbf0 
Fixes: google#7664 (hopefully)
@jkuszmaul jkuszmaul mentioned this issue Dec 3, 2022
Merged
sunwen18 pushed a commit to sunwen18/flatbuffers that referenced this issue Dec 25, 2022
@jkuszmaul @dbaileychess
Upgrade rules_go for Bazel 7.0 support (google#7691)
9e16d92 
Fixes: google#7664 (hopefully)

Co-authored-by: Derek Bailey <derekbailey@google.com>
candhyan pushed a commit to mediaz/flatbuffers that referenced this issue Jan 2, 2023
@jkuszmaul @dbaileychess @candhyan
Upgrade rules_go for Bazel 7.0 support (google#7691)
1e3b6a5 
Fixes: google#7664 (hopefully)

Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this issue Oct 29, 2024
@jkuszmaul @dbaileychess
Upgrade rules_go for Bazel 7.0 support (google#7691)
7fc026d 
Fixes: google#7664 (hopefully)

Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this issue Oct 29, 2024
@jkuszmaul @dbaileychess
Upgrade rules_go for Bazel 7.0 support (google#7691)
5522504 
Fixes: google#7664 (hopefully)

Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade rules_go for Bazel 7.0 support jkuszmaul/flatbuffers
3 participants
@dbaileychess @jkuszmaul @keertk