Add a way to query the transform matrix of a surface texture from the driver #8489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflinger
requested changes
Mar 5, 2025
|
done |
pixelflinger
approved these changes
Mar 5, 2025
z3moon
approved these changes
Mar 6, 2025
|
Can we please merge this in now? |
z3moon
pushed a commit
that referenced
this pull request
Mar 10, 2025
… driver (#8489) * Add a way to query the transform matrix of a surface texture from the driver BUGS=[399959254]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: https://developer.android.com/reference/android/graphics/SurfaceTexture
When sampling from the texture one should first transform the texture coordinates using the matrix queried via getTransformMatrix(float[]). The transform matrix may change each time updateTexImage() is called, so it should be re-queried each time the texture image is updated.
Exposing the matrix to the driver is the first step to being able to apply it to the uniform in the shader.