-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ARIA attributes from taxonomy lists #1072
Conversation
3a633dc
to
11dd63d
Compare
@at055612 - PTAL and approve if this solution is suitable for you. |
@chalin Agree with making the leaf link enabled on the taxonomy results. I did wander about keeping the |
11dd63d
to
bd5260a
Compare
5c6d19c
to
15bb6e0
Compare
LGTM, though agree with @at055612 that a comment for the regex replace would be useful, especially for future users who might want to modify or override the partial. |
97b376b
to
08130c0
Compare
Added a comment and rebased. PTAL |
08130c0
to
ff62fd4
Compare
ff62fd4
to
bd70b0d
Compare
@LisaFC - just a reminder that this is ready for your review. |
bd70b0d
to
8bda2ca
Compare
I've chosen to avoid complicating the logic of the breadcrumbs partial since it's complicated enough already. This PR implements what I proposed earlier: it strips out unnecessary classes and irrelevant ARIA labels from the "breadcrumbs" used in the taxonomy lists.
You'll notice that I've removed the
disabled
state from the last breadcrumb since it no longer makes sense to disable it (because we're not on that page anymore :)).Preview: https://deploy-preview-1072--docsydocs.netlify.app/categories/taxonomies/
Screenshots
Before:
After:
/cc @at055612