Move dagger-android to androidx #1721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves google#1652 Resolves google#1619 Resolves google#1248 Resolves google#1489 Resolves google#1444 Resolves google#1313 Resolves google#1264 Enables better support for newer androidx subprojects like google#1271, but I feel we need to start somewhere. This unblocks that by making the initial move to androidx as a namespace, and then splitting up newer artifacts out of this (and progressively making dagger-android-support increasingly just a shim that delegates to them) is a healthy approach.
|
CI failure seems unrelated still. Running |
|
Closed by f45213e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1652
Resolves #1619
Resolves #1248
Resolves #1489
Resolves #1444
Resolves #1313
Resolves #1264
Enables better support for newer androidx subprojects like #1271.
I understand there have been a number of prior discussions about next steps, namely this one. I worry that the argument that any move to androidx should either be completely split up artifacts or nothing has actively prevented progress on this front though, and think this is a positive first step. This unblocks that by making the initial move to androidx as a namespace, and then splitting up newer artifacts out of this (and progressively making dagger-android-support increasingly just a shim that delegates to them) is a possible healthy approach.
Also I believe the long term vision for dagger-android has changed significantly since those past discussions with the involvement of the androidx folks and the "Opinionated DI" talk from Android Dev Summit.