Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hilt] Fragment transition is broken #2481

Closed
anastr opened this issue Mar 16, 2021 · 1 comment · Fixed by #2485
Closed

[Hilt] Fragment transition is broken #2481

anastr opened this issue Mar 16, 2021 · 1 comment · Fixed by #2485

Comments

@anastr
Copy link

anastr commented Mar 16, 2021 •
edited
Loading

After updating to Hilt 2.33-beta our transition animation is acting weird and not working correctly. I think it's because of moving to fragment:1.3.0.
By looking for a solution, I found this issue should have been fixed according to this bug. New release of fragment 1.3.1 has critical lifecycle-aware bugs fixed and I think Hilt should be moved to that version.
@Chang-Eric
Copy link
Member

Thanks for the report, we should update that dependency. In the meantime, I think you should be able to bump your own dependency on fragment to fix this.

copybara-service bot pushed a commit that referenced this issue Mar 16, 2021
@Chang-Eric
Bump fragment dependency to 1.3.1 and activity to 1.2.1.
11959cb 
Fixes #2481

RELNOTES=Bump fragment dependency to 1.3.1 and activity to 1.2.1.
PiperOrigin-RevId: 363218826
@copybara-service copybara-service bot mentioned this issue Mar 16, 2021
Merged
copybara-service bot pushed a commit that referenced this issue Mar 16, 2021
@Chang-Eric
Bump fragment dependency to 1.3.1 and activity to 1.2.1.
552e333 
Fixes #2481

RELNOTES=Bump fragment dependency to 1.3.1 and activity to 1.2.1.
PiperOrigin-RevId: 363218826
copybara-service bot pushed a commit that referenced this issue Mar 16, 2021
@Chang-Eric
Bump fragment dependency to 1.3.1 and activity to 1.2.1.
d57a9a6 
Fixes #2481

RELNOTES=Bump fragment dependency to 1.3.1 and activity to 1.2.1.
PiperOrigin-RevId: 363218826
copybara-service bot pushed a commit that referenced this issue Mar 16, 2021
@Chang-Eric
Bump fragment dependency to 1.3.1 and activity to 1.2.1.
1763649 
Fixes #2481

RELNOTES=Bump fragment dependency to 1.3.1 and activity to 1.2.1.
PiperOrigin-RevId: 363218826
copybara-service bot pushed a commit that referenced this issue Mar 16, 2021
@Chang-Eric
Bump fragment dependency to 1.3.1 and activity to 1.2.1.
40a6646 
Fixes #2481

RELNOTES=Bump fragment dependency to 1.3.1 and activity to 1.2.1.
PiperOrigin-RevId: 363218826
copybara-service bot pushed a commit that referenced this issue Mar 16, 2021
@Chang-Eric
Bump fragment dependency to 1.3.1 and activity to 1.2.1.
0ed6b97 
Fixes #2481

RELNOTES=Bump fragment dependency to 1.3.1 and activity to 1.2.1.
PiperOrigin-RevId: 363218826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump fragment dependency to 1.3.1 and activity to 1.2.1. google/dagger
2 participants
@anastr @Chang-Eric