Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In DaggerAppCompatActivity 2.26 not suppoted constructor with contentLayoutId #1734

Closed
frist008 opened this issue Feb 4, 2020 · 0 comments · Fixed by #1746
Closed

In DaggerAppCompatActivity 2.26 not suppoted constructor with contentLayoutId #1734

frist008 opened this issue Feb 4, 2020 · 0 comments · Fixed by #1746
Assignees
@danysantiago
Labels
area: dagger-android

Comments

@frist008
Copy link

frist008 commented Feb 4, 2020

Why not add support for new constructors?

    @ContentView
    public AppCompatActivity(@LayoutRes int contentLayoutId) {
        super(contentLayoutId);
    }
@chibatching chibatching mentioned this issue Feb 17, 2020
Closed
@danysantiago danysantiago self-assigned this Feb 19, 2020
@kluever kluever mentioned this issue Feb 21, 2020
Merged
kluever pushed a commit that referenced this issue Feb 21, 2020
@chibatching @kluever
Add support constructor with content layout id for AndroidX
211eb09 
This PR add constructor with content layout id for AndroidX version
DaggerAppCompatActivity and DaggerFragment.

Fixes #1734
Closes #1741

RELNOTES=Add support constructor with content layout id for AndroidX

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=296257246
kluever pushed a commit that referenced this issue Feb 21, 2020
@chibatching @kluever
Add support constructor with content layout id for AndroidX
22b2726 
This PR add constructor with content layout id for AndroidX version
DaggerAppCompatActivity and DaggerFragment.

Fixes #1734
Closes #1741

RELNOTES=Add support constructor with content layout id for AndroidX

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=296257246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danysantiago danysantiago

Labels
area: dagger-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MOE Sync 2020-02-21 google/dagger
2 participants
@danysantiago @frist008