Skip to content

Commit

Permalink
A little more prep for --incompatible_load_java_rules_from_bzl.
Browse files Browse the repository at this point in the history
Sorry for missing these in CL 297608393.

(But note that, even after this CL, there is still a breakage when building Dagger with --incompatible_load_java_rules_from_bzl. I'm trying to get to the bottom of it in bazelbuild/bazel#10839.)

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=297822279
  • Loading branch information
cpovirk committed Feb 28, 2020
1 parent 072ece8 commit df20ca2
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
4 changes: 4 additions & 0 deletions java/dagger/internal/codegen/javac/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
# Description:
# A library for javac the javac plugin module.

load("@rules_java//java:defs.bzl", "java_library")

package(default_visibility = ["//:src"])

java_library(
Expand All @@ -34,6 +36,8 @@ java_library(
)

# buildifier: disable=no-effect
load("@rules_java//java:defs.bzl", "java_import")

# Replacement for @bazel_tools//third_party/java/jdk/langtools:javac, which seems to have gone away?
java_import(
name = "javac-import",
Expand Down
4 changes: 4 additions & 0 deletions java/dagger/internal/codegen/kythe/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
# Description:
# A library for the kythe plugin.

load("@rules_java//java:defs.bzl", "java_library")

package(default_visibility = ["//:src"])

java_library(
Expand All @@ -37,6 +39,8 @@ java_library(
)

# buildifier: disable=no-effect
load("@rules_java//java:defs.bzl", "java_import")

# A _deploy.jar consisting of the java_librarys in https://github.com/kythe/kythe needed to build a
# Kythe plugin
# TODO(ronshapiro): replace this with a http_archive of the next release in
Expand Down
2 changes: 2 additions & 0 deletions java/dagger/testing/compile/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
# Description:
# Helpers class for java compiler tests.

load("@rules_java//java:defs.bzl", "java_library")

package(default_visibility = ["//:src"])

java_library(
Expand Down

0 comments on commit df20ca2

Please sign in to comment.