Skip to content

Commit

Permalink
Add proguard rules to keep EntryPoint classes so optimizers don't rem…
Browse files Browse the repository at this point in the history
…ove them.

RELNOTES=Add proguard rules to keep EntryPoint classes so optimizers don't remove them.
PiperOrigin-RevId: 363988696
  • Loading branch information
Chang-Eric authored and Dagger Team committed Mar 19, 2021
1 parent f7e02d6 commit 96171b0
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 0 deletions.
1 change: 1 addition & 0 deletions java/dagger/hilt/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ java_library(
# TODO(bcorso): Consider using a separate processor to validate @EntryPoint.
"//java/dagger/hilt/processor/internal/aggregateddeps:plugin",
],
proguard_specs = ["proguard-rules.pro"],
deps = [
":generates_root_input",
":package_info",
Expand Down
4 changes: 4 additions & 0 deletions java/dagger/hilt/android/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ android_library(
exported_plugins = [
"//java/dagger/hilt/processor/internal/aggregateddeps:plugin",
],
proguard_specs = ["proguard-rules.pro"],
deps = [
":package_info",
"//:dagger_with_compiler",
Expand Down Expand Up @@ -226,7 +227,10 @@ gen_maven_artifact(
manifest = "AndroidManifest.xml",
packaging = "aar",
proguard_specs = [
"//java/dagger/hilt:proguard-rules.pro",
":proguard-rules.pro",
"//java/dagger/hilt/android/lifecycle:proguard-rules.pro",
"//java/dagger/hilt/internal:proguard-rules.pro",
],
)

Expand Down
3 changes: 3 additions & 0 deletions java/dagger/hilt/android/proguard-rules.pro
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Keep for the reflective cast done in EntryPoints.
# See b/183070411#comment4 for more info.
-keep,allowobfuscation,allowshrinking @dagger.hilt.android.EarlyEntryPoint class *
2 changes: 2 additions & 0 deletions java/dagger/hilt/internal/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,14 @@ java_library(
java_library(
name = "component_entry_point",
srcs = ["ComponentEntryPoint.java"],
proguard_specs = ["proguard-rules.pro"],
deps = ["//java/dagger/hilt:generates_root_input"],
)

java_library(
name = "generated_entry_point",
srcs = ["GeneratedEntryPoint.java"],
proguard_specs = ["proguard-rules.pro"],
deps = ["//java/dagger/hilt:generates_root_input"],
)

Expand Down
4 changes: 4 additions & 0 deletions java/dagger/hilt/internal/proguard-rules.pro
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Keep for the reflective cast done in EntryPoints.
# See b/183070411#comment4 for more info.
-keep,allowobfuscation,allowshrinking @dagger.hilt.internal.ComponentEntryPoint class *
-keep,allowobfuscation,allowshrinking @dagger.hilt.internal.GeneratedEntryPoint class *
3 changes: 3 additions & 0 deletions java/dagger/hilt/proguard-rules.pro
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Keep for the reflective cast done in EntryPoints.
# See b/183070411#comment4 for more info.
-keep,allowobfuscation,allowshrinking @dagger.hilt.EntryPoint class *

0 comments on commit 96171b0

Please sign in to comment.