Strictly verify Hilt compiler flag inputs.

RELNOTES=Strictly verify Hilt compiler flag inputs. PiperOrigin-RevId: 396668785
google · Sep 14, 2021 · 742ba95 · 742ba95
1 parent b37be92
commit 742ba95
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/java/dagger/hilt/processor/internal/BUILD b/java/dagger/hilt/processor/internal/BUILD
@@ -156,6 +156,7 @@ java_library(
     srcs = ["HiltCompilerOptions.java"],
     deps = [
         ":processor_errors",
+        "//java/dagger/internal/guava:base",
         "//java/dagger/internal/guava:collect",
         "@google_bazel_common//third_party/java/javapoet",
     ],

diff --git a/java/dagger/hilt/processor/internal/HiltCompilerOptions.java b/java/dagger/hilt/processor/internal/HiltCompilerOptions.java
@@ -16,6 +16,7 @@
 
 package dagger.hilt.processor.internal;
 
+import com.google.common.base.Ascii;
 import com.google.common.collect.ImmutableSet;
 import java.util.Arrays;
 import java.util.Set;
@@ -124,8 +125,22 @@ boolean get(ProcessingEnvironment env) {
       if (value == null) {
         return defaultValue;
       }
-      // TODO(danysantiago): Strictly verify input, either 'true' or 'false' and nothing else.
-      return Boolean.parseBoolean(value);
+
+      // Using Boolean.parseBoolean will turn any non-"true" value into false. Strictly verify the
+      // inputs to reduce user errors.
+      String lowercaseValue = Ascii.toLowerCase(value);
+      switch (lowercaseValue) {
+        case "true":
+          return true;
+        case "false":
+          return false;
+        default:
+          throw new IllegalStateException(
+              "Expected a value of true/false for the flag \""
+                  + name
+                  + "\". Got instead: "
+                  + value);
+      }
     }
 
     String getQualifiedName() {