Make the generated Provider for component dependency types final.

RELNOTES=n/a PiperOrigin-RevId: 370721981
google · Apr 27, 2021 · 58c3bf9 · 58c3bf9
1 parent bfdb109
commit 58c3bf9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/java/dagger/internal/codegen/writing/DependencyMethodProviderCreationExpression.java b/java/dagger/internal/codegen/writing/DependencyMethodProviderCreationExpression.java
@@ -96,7 +96,7 @@ public CodeBlock creationExpression() {
         COMPONENT_PROVISION_FACTORY,
         classBuilder(factoryClassName())
             .addSuperinterface(providerOf(keyType))
-            .addModifiers(PRIVATE, STATIC)
+            .addModifiers(PRIVATE, STATIC, FINAL)
             .addField(dependencyClassName, dependency().variableName(), PRIVATE, FINAL)
             .addMethod(
                 constructorBuilder()

diff --git a/javatests/dagger/internal/codegen/ComponentProcessorTest.java b/javatests/dagger/internal/codegen/ComponentProcessorTest.java
@@ -1227,7 +1227,7 @@ public void testDefaultPackage() {
                 "  }")
             .addLinesIn(
                 DEFAULT_MODE,
-                "  private static class test_AComponent_a implements Provider<A> {",
+                "  private static final class test_AComponent_a implements Provider<A> {",
                 "    private final AComponent aComponent;",
                 "    ",
                 "    test_AComponent_a(AComponent aComponent) {",