Fix bug in speaker notes that broke navigating to next slide #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e speaker notes. The reason for that is that the "rel" attribute contained "prev" respective "next prefetch". Change this selector to use the ~= selector See: https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors#attrvalue_2
|
What behavior exactly is this fixing? I tried it locally and navigating to the right still breaks the speaker notes (speaker notes become disconnected from the main slides, and the speaker note section re-appears at the bottom of the regular notes). Was there a different issue that this fixes? |
|
I'm aware of the second issue and that is some more difficult communication issue between the windows - I described the root cause that I see in #2004 (comment) |
|
@randomPoison This change is fixing only the issue that the hash "#speaker-notes-open" was not appended to the urls when navigating to "next" thus the next speaker note slide did not know it was a speaker note window |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change this selector to use the ~= selector to test if a white space separated word "prev" or "next" is contained
Fixes a speaker notes bug that did not allow going to the next slide in the speaker notes.
The reason for that is that the "rel" attribute contained "prev" respective "next prefetch".
See: https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors#attrvalue_2
This fixes part of #2004 when going to the right (containing "prefetch").