Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a quick way to visualize a job environment #4644

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Add a quick way to visualize a job environment #4644

merged 1 commit into from
Jan 30, 2025

Conversation

ParisMeuleman
Copy link
Contributor

With templates, it can sometimes be a bit difficult to know which environment a given job has. This is a QoL changedisplaying the merged environment:

Screenshot from 2025-01-27 19-01-35

@jonathanmetzman
Copy link
Collaborator

/gcbrun

jonathanmetzman
jonathanmetzman approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks!

@ParisMeuleman ParisMeuleman force-pushed the env_viz branch 2 times, most recently from bc76715 to 8e6409c Compare January 28, 2025 21:24
@ParisMeuleman
Copy link
Contributor Author

last changes were just rebases on newest Chrome branch, though I'm happy to land this in master first if you think that's appropriate.

@jonathanmetzman
Copy link
Collaborator

last changes were just rebases on newest Chrome branch, though I'm happy to land this in master first if you think that's appropriate.

Could you land this in master first? It will make it easier to merge the branches.

@ParisMeuleman ParisMeuleman changed the base branch from chrome to master January 30, 2025 08:56
@ParisMeuleman
Copy link
Contributor Author

last changes were just rebases on newest Chrome branch, though I'm happy to land this in master first if you think that's appropriate.

Could you land this in master first? It will make it easier to merge the branches.

done rebasing.

@jonathanmetzman
Copy link
Collaborator

/gcbrun

@jonathanmetzman jonathanmetzman merged commit 50a3f34 into google:master Jan 30, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmetzman jonathanmetzman jonathanmetzman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ParisMeuleman @jonathanmetzman