Remove Clif_PyObjFrom for std::string.

`std::string` is implicitly convertible to `std::string_view`. So it is safe to only keep the `Clif_PyObjFrom` conversion function for `std::string_view`. PiperOrigin-RevId: 406464119
google · Oct 29, 2021 · ef5fa11 · ef5fa11
1 parent f349e2a
commit ef5fa11
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/clif/python/types.cc b/clif/python/types.cc
@@ -21,10 +21,6 @@ namespace clif {
 //// To Python conversions.
 
 // bytes
-PyObject* Clif_PyObjFrom(const std::string& c, const py::PostConv& pc) {
-  return pc.Apply(PyBytes_FromStringAndSize(c.data(), c.size()));
-}
-
 PyObject* Clif_PyObjFrom(std::string_view c, const py::PostConv& pc) {
   return pc.Apply(PyBytes_FromStringAndSize(c.data(), c.size()));
 }

diff --git a/clif/python/types.h b/clif/python/types.h
@@ -169,7 +169,6 @@ inline PyObject* Clif_PyObjFrom(T c, const py::PostConv& pc) {
   return pc.Apply(PyBool_FromLong(c));
 }
 
-PyObject* Clif_PyObjFrom(const std::string&, const py::PostConv&);
 PyObject* Clif_PyObjFrom(std::string_view, const py::PostConv&);
 // CLIF use `::std::string` as bytes