Lint fixes (#949)

common/runes/buffer.go

@@ -131,8 +131,8 @@ func NewBuffer(data string) Buffer {
 	return buf
 }
 
-// NewBuffer returns an efficient implementation of Buffer for the given text based on the ranges of
-// the encoded code points contained within, as well as returning the line offsets.
+// NewBufferAndLineOffsets returns an efficient implementation of Buffer for the given text based on
+// the ranges of the encoded code points contained within, as well as returning the line offsets.
 //
 // Code points are represented as an array of byte, uint16, or rune. This approach ensures that
 // each index represents a code point by itself without needing to use an array of rune. At first

ext/sets_test.go

@@ -24,7 +24,8 @@ import (
 	"github.com/google/cel-go/checker"
 	"github.com/google/cel-go/common/types"
 	"github.com/google/cel-go/common/types/ref"
-	"github.com/google/cel-go/test/proto3pb"
+
+	proto3pb "github.com/google/cel-go/test/proto3pb"
 )
 
 func TestSets(t *testing.T) {

parser/helper.go

@@ -161,7 +161,7 @@ func (p *parserHelper) id(ctx any) int64 {
 	return id
 }
 
-func (p *parserHelper) deleteId(id int64) {
+func (p *parserHelper) deleteID(id int64) {
 	p.sourceInfo.ClearOffsetRange(id)
 	if id == p.nextID-1 {
 		p.nextID--

parser/parser.go

@@ -921,7 +921,7 @@ func (p *parser) expandMacro(exprID int64, function string, target ast.Expr, arg
 		if loc == nil {
 			loc = p.helper.getLocation(exprID)
 		}
-		p.helper.deleteId(exprID)
+		p.helper.deleteID(exprID)
 		return p.reportError(loc, err.Message), true
 	}
 	// A nil value from the macro indicates that the macro implementation decided that
@@ -932,7 +932,7 @@ func (p *parser) expandMacro(exprID int64, function string, target ast.Expr, arg
 	if p.populateMacroCalls {
 		p.helper.addMacroCall(expr.ID(), function, target, args...)
 	}
-	p.helper.deleteId(exprID)
+	p.helper.deleteID(exprID)
 	return expr, true
 }
 

policy/BUILD.bazel

@@ -46,8 +46,8 @@ go_test(
     srcs = [
         "compiler_test.go",
         "config_test.go",
+        "helper_test.go",        
         "parser_test.go",
-        "test.go",
     ],
     data = glob(["testdata/**"]),
     embed = [":go_default_library"],

policy/parser.go

@@ -339,6 +339,7 @@ type TagVisitor interface {
 	VariableTag(ParserContext, int64, string, *yaml.Node, *Policy, *Variable)
 }
 
+// DefaultTagVisitor creates a tag visitor which produces errors for any non-canonical YAML tag.
 func DefaultTagVisitor() TagVisitor {
 	return defaultTagVisitor{}
 }

policy/testdata/k8s/policy.yaml

@@ -30,7 +30,7 @@ spec:
     expression: "resource.labels.?break_glass.orValue('false') == 'true'"
   validations:
   - expression: >
-      variables.break_glass || 
+      variables.break_glass ||
         resource.containers.all(c, c.startsWith(variables.env + '.'))
     messageExpression: >
       'only %s containers are allowed in namespace %s'