Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raze panics when Cargo.toml doesn't contain raze metadata #377

Closed
gkelly opened this issue Feb 21, 2021 · 1 comment
Closed

raze panics when Cargo.toml doesn't contain raze metadata #377

gkelly opened this issue Feb 21, 2021 · 1 comment

Comments

@gkelly
Copy link
Contributor

gkelly commented Feb 21, 2021

Pretty easy to replicate. cargo new somewhere and then cargo raze it:

gkelly@praxis> cargo new --bin razor
     Created binary (application) `razor` package
gkelly@praxis> cd razor
gkelly@praxis> cargo raze
thread 'main' panicked at 'index out of bounds: the len is 0 but the index is 0', src/settings.rs:640:24
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
gkelly added a commit to gkelly/cargo-raze that referenced this issue Feb 21, 2021
Also add a test that ensures the error is reported and a panic doesn't
occur.
gkelly added a commit to gkelly/cargo-raze that referenced this issue Feb 21, 2021
Also add a test that ensures the error is reported and a panic doesn't
occur.
dfreese pushed a commit that referenced this issue Feb 21, 2021
Also add a test that ensures the error is reported and a panic doesn't
occur.
@gkelly
Copy link
Contributor Author

gkelly commented Feb 21, 2021

With #378 merged this now looks like:

gkelly@praxis> cargo raze
Error: Raze failed with cause: "No raze settings were specified in the Cargo.toml file, see README.md for details on expected fields"

@gkelly gkelly closed this as completed Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant