Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for searching volatile-containers.json #3644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ja14000
Copy link

@ja14000 ja14000 commented Jan 9, 2025

cAdvisor currently does not search in volatile-containers.json when looking for a given container ID, which can result in an error like the one shown below:

cadvisor-start [manager.go:1116] Failed to create existing container: /machine.slice/libpod-<id>.scope: open /var/lib/containers/storage/overlay-containers/containers.json: no such file or directory

This PR adds logic to search in volatile-containers.json if the container is not found in containers.json.

Added logic to search for layer id in volatile-containers.json, if not found in containers.json
Copy link

google-cla bot commented Jan 9, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant