Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bump runc to d5b4a3eddbe4c890843da971b64f45a0f023f4db #1860

Closed
wants to merge 1 commit into from

Conversation

vikaschoudhary16
Copy link
Contributor

@vikaschoudhary16 vikaschoudhary16 commented Jan 12, 2018

What this PR does / why we need it:
This fixes a race condition in runc/systemd at container creation time
opencontainers/runc#1683

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
Needed by kubernetes/kubernetes#58117

Release note:

None

@k8s-ci-robot
Copy link
Collaborator

@vikaschoudhary16: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cadvisor-e2e 0804052 link /test pull-cadvisor-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -2,9 +2,6 @@
"ImportPath": "github.com/google/cadvisor",
"GoVersion": "go1.9",
"GodepVersion": "v79",
"Packages": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dint remove manually. godep save did.
godep removed couple of packages which are needed actually. for ex:
github.com/SeanDolphin/bqschema

Will sort out.

-Thanks

@vikaschoudhary16 vikaschoudhary16 changed the title Bump runc to d5b4a3eddbe4c890843da971b64f45a0f023f4db [WIP] Bump runc to d5b4a3eddbe4c890843da971b64f45a0f023f4db Jan 12, 2018
@dashpole
Copy link
Collaborator

it could be because you need to run godep restore ./... and godep save ./...

@dashpole
Copy link
Collaborator

and occasionally, I need to run godep save ./... more than once.

@vikaschoudhary16
Copy link
Contributor Author

Moved here, #1861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants