Fix python build #407
Merged
Fix python build #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 10, 2016 18:05
Removed unnecessary builds for homebrew and system python. We only use the official Mac Python distributions from Python.org. The wheels compiled with those will work on both homebrew Python and the OSX built-in Python.
I need to use 'source' command to activate the python virtual environment, but apparently that is not available on Ubuntu's default /bin/sh
1b86c09 to
13b8e7f
Compare
|
should be good to merge now. |
|
Sorry, I guess I screwed this up when I added the CMake builds :( Regarding "source $file", the standard version is ". $file". Doesn't really matter if .travis.sh since that's only supposed to run on Travis, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to source the virtual environment at the
scriptandafter_successstages inside.travis.shscript.We can build and deploy only OSX wheels for now, but I will work on adding
manylinux1support later.There's no need to build wheels using homebrew python (64bit only), as the wheels produced by Mac Python (from Python.org) are "universal", so they will work on homebrew python as well.