feat: Add support for toggling readonly mode. #8750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he injection options.
7e235c3 to
a1b510c
Compare
rachel-fenichel
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8732
Proposed Changes
This PR adds a
setIsReadOnly()method toWorkspacethat allows dynamically toggling readonly status at runtime. Previously, the readonly option could only be set at injection time, and thus required reinjecting the workspace to modify.For backwards compatibility, the
readOnlyfield in theoptionsdictionary is updated when the state is changed, since this was previously the only way to observe the readonly status. A getter,isReadOnly(), has also been introduced, and core has been refactored to use it.Reason for Changes
This unblocks #8732, but also has potential instructional usecases.