-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Migrating every theme to TypeScript. #2474
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @tgbhy. Thanks for this useful PR! The changes look good but there are some additional steps needed before we can accept the PR:
|
Working on it ! |
The basics
The details
Resolves
Fixes #2158
Proposed Changes
Migrate every theme sample to TypeScript.
Reason for Changes
It would be usable in TypeScript like explained in the fixed issue.
Test Coverage
Manually tested with a Windows 10 PC and Brave Browser.
I tested on using a default installation of Blockly and recreating the schema of each readme-media/Theme.png