feat: Create Hacker mode theme #1988

[shivalipatel6]

I created a theme with a black background, black block fill for all blocks, a white shadow for all blocks (still working on putting in an actual outline), dark toolbox, dark flyout, and monospace text. I am still working on putting in green text for all block text. Need to fix CSS issue first.

The basics

• [ X] I validated my changes

The details

Resolves

Fixes #1988

Proposed Changes

This pull request creates a new blockly theme that has a black background for everything, black fill in for blocks and a white highlight. Theme is currently incomplete as it is missing green text color, but it will be fixed later once some CSS work is fixed.

Reason for Changes

Test Coverage

Documentation

Once the theme is made public, the documentation about themes will need to be updated to let users know the theme exists. As well documentation about how to download the theme will be needed.

Additional Information

[BeksOmega]

This is looking great so far! Thank you for putting the work into this and dealing with all of the crazy rebasing =)

[maribethb]

Hi @shivalipatel6 you can also run the create-package script with the --first-party flag and it will use the correct values for many of the things Beka noted. Whether you want to re-run the script and then re-apply your changes, or just fix the issues Beka noted manually is up to you!

[BeksOmega]

Thanks for the fixes! Just a few more nits then this should be good to go =)

[BeksOmega]

@shivalipatel6 Please resolve the build errors. You should be able to run npm run build to reproduce the problem. Let me know if you need help!

[shivalipatel6]

I fixed up the build issues, but I am still unsure what is up with the format issues... I could use some pointers for figuring this out.

[BeksOmega]

I fixed up the build issues, but I am still unsure what is up with the format issues... I could use some pointers for figuring this out.

Can you try running npm ci and then npm run format from the root level of the repository? That should create some changes you can commit to fix it!

[shivalipatel6]

I fixed up the build issues, but I am still unsure what is up with the format issues... I could use some pointers for figuring this out.

Can you try running npm ci and then npm run format from the root level of the repository? That should create some changes you can commit to fix it!

I was able to run both commands and produce changes, but it was unable to fix the format issues. Is there anything I can run that will help me diagonse these problems?

[BeksOmega]

I fixed up the build issues, but I am still unsure what is up with the format issues... I could use some pointers for figuring this out.

Can you try running npm ci and then npm run format from the root level of the repository? That should create some changes you can commit to fix it!

I was able to run both commands and produce changes, but it was unable to fix the format issues. Is there anything I can run that will help me diagonse these problems?

Hm you're right. I also pulled your branch and the format check passed.

Could you try rebasing onto the latest master and then rerunning the formatting commands? It could be that the quoting change you fixed in your other PR (thank you again!) is causing conflicts.

[shivalipatel6]

I ran npm ci and npm run format after I rebased and merged the changes from master into this branch but there was no changes to commit...

[BeksOmega]

Hiya @shivalipatel6 Wanted to let you know I saw this but my team is doing a hackathon this week! So I'll get back to you about this in a few days. Sorry for the delay!

[shivalipatel6]

Hiya @shivalipatel6 Wanted to let you know I saw this but my team is doing a hackathon this week! So I'll get back to you about this in a few days. Sorry for the delay!

Have fun at the hackathon!! Good luck with your projects!

[BeksOmega]

I pushed a commit to your branch with the formatting fixes! Thanks for the work on this @shivalipatel6 =)