Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sample p5 app #2085

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Conversation

maribethb
Copy link
Contributor

The basics

The details

Resolves

Proposed Changes

Sample app with p5 blocks for hackathon. Note this PR is to the p5-sample-app branch, not master. I created a fresh sample app and then rebased my old old p5 sample onto it, so it should be the most recent version of the sample app code.

Reason for Changes

Test Coverage

Documentation

Additional Information

@maribethb maribethb requested a review from BeksOmega December 1, 2023 01:50
@maribethb maribethb requested a review from a team as a code owner December 1, 2023 01:50
Copy link
Contributor

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits, but I'm also happy for you to merge this and I can fix up!

examples/sample-p5-app/src/generators/javascript.js Outdated Show resolved Hide resolved
examples/sample-p5-app/src/index.js Show resolved Hide resolved
examples/sample-p5-app/src/serialization.js Show resolved Hide resolved
@BeksOmega BeksOmega merged commit ea36fb6 into google:p5-sample-app Dec 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants