-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:enables strict mode for workspace_search #2050
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Heya @Vidip-Ghosh It looks like your branch caught some unrelated changes to the continuous toolbox and content highlight. Could you remove those changes or open another PR without them? |
I've removed those changes from my PR. Please check if its alright. |
Hello! It looks like you've deleted the files, which is not what we're looking for :/ We want those files to be unchanged, because they're unrelated to this fix. There are fancy ways to undo changes with git, but you might be better off starting a new branch and redoing your changes. |
Okay. I'll create a new branch & push all the changes. |
@BeksOmega Please review my PR #2054 |
The basics
Enabling strict mode in workspace_search.ts
The details
Resolves
Fixes #2032
Proposed Changes
I've enabled the strict mode for workspace_search.ts and there were some type after applying strict mode. So I've solved them by adding
!
where I gotObject is possibly null
Reason for Changes
Test Coverage
Documentation
Additional Information