Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix ghpage demos #1974

Merged
merged 1 commit into from
Sep 26, 2023
Merged

chore: fix ghpage demos #1974

merged 1 commit into from
Sep 26, 2023

Conversation

alicialics
Copy link
Contributor

@alicialics alicialics commented Sep 25, 2023 •
edited
Loading

The basics

The details

Resolves

Fixes #1894

Proposed Changes

Run lerna run build before lerna run predeploy

Reason for Changes

Test Coverage

Tested locally via npm run test:ghpages

Documentation

Additional Information

cc @maribethb

@alicialics alicialics requested a review from a team as a code owner September 25, 2023 21:15
@alicialics alicialics requested review from rachel-fenichel and removed request for a team September 25, 2023 21:15
@alicialics alicialics changed the base branch from master to osd September 25, 2023 21:16
rachel-fenichel
rachel-fenichel approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rachel-fenichel rachel-fenichel merged commit b76046b into google:osd Sep 26, 2023
@rachel-fenichel rachel-fenichel mentioned this pull request Sep 26, 2023
Merged
1 task
@alicialics alicialics deleted the fix_ghpage_demos branch September 27, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachel-fenichel rachel-fenichel rachel-fenichel approved these changes

Assignees

@rachel-fenichel rachel-fenichel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public demo of field-colour-hsv-sliders does not launch
2 participants
@alicialics @rachel-fenichel