Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: Publish types for shadow-block-converter #1965

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fixes: Publish types for shadow-block-converter #1965

merged 1 commit into from
Sep 22, 2023

Conversation

humera811
Copy link
Contributor

@humera811 humera811 commented Sep 22, 2023 •
edited
Loading

The basics

The details

Resolves

Proposed Changes

  • add "types": "./dist/index.d.ts"

Reason for Changes

  • Currently types for this plugin are not being exported :/

Test Coverage

Documentation

Additional Information

@humera811 humera811 requested a review from a team as a code owner September 22, 2023 21:28
@humera811 humera811 requested review from johnnesky and removed request for a team September 22, 2023 21:28
@johnnesky
Copy link
Member

Excellent work, thank you!

@johnnesky johnnesky merged commit 3345fa8 into google:osd Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnesky johnnesky johnnesky approved these changes

Assignees

@johnnesky johnnesky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish types for shadow-block-converter
2 participants
@humera811 @johnnesky