Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add the type property to the package.json next to the "main" prop… #1955

Merged

Conversation

shivalipatel6
Copy link
Contributor

@shivalipatel6 shivalipatel6 commented Sep 22, 2023

…erty:

The basics

The details

Add the following property to the package.json next to the "main" property: "types": "./dist/index.d.ts"

Resolves

Makes sure that the types for this plug in are exported.

Fixes #1904

Proposed Changes

Reason for Changes

Currently types for this plugin are not being exported :/

Test Coverage

Documentation

Additional Information

@shivalipatel6 shivalipatel6 requested a review from a team as a code owner September 22, 2023 18:25
@shivalipatel6 shivalipatel6 requested review from BeksOmega and removed request for a team September 22, 2023 18:25
@google-cla
Copy link

google-cla bot commented Sep 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 22, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@BeksOmega BeksOmega changed the title fix:Add the type property to the package.json next to the "main" prop… fix: Add the type property to the package.json next to the "main" prop… Sep 22, 2023
@BeksOmega
Copy link
Contributor

Heya @shivalipatel6 =) could you sign the CLA? Then if CI passes this should be good to go!

@shivalipatel6
Copy link
Contributor Author

Heya @shivalipatel6 =) could you sign the CLA? Then if CI passes this should be good to go!

I have signed the CLA! Is there anything else I need to do?

@BeksOmega
Copy link
Contributor

Looks great! Thank you so much for your work on this =)

@BeksOmega BeksOmega merged commit abc713b into google:osd Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish types for field-grid-dropdown
2 participants